Can't pick up traps with spacebar
Video: https://youtu.be/A5yfMvn1Sl4
Tested with no other mods on

Originally posted by Catto123:

Can't pick up traps with spacebar
Video: https://youtu.be/A5yfMvn1Sl4
Tested with no other mods on

Huh that's weird, what settings do you have enabled? I can't quite reproduce it on my own

Originally posted by Catto123:

Can't pick up traps with spacebar
Video: https://youtu.be/A5yfMvn1Sl4
Tested with no other mods on

While I couldn't repeat this bug on my own I pushed an update that should hopefully fixed the bug. Can you tell me if the update fixed the problem for you?

Your update fixed the issue, and I'm not sure what could have been causing it, these were my settings if it helps: https://gyazo.com/929d955139b38bb53d158080f1e1482b
I really appreciate you going out of your way to help fix my issue, and heck, to even make this mod, thank you so much!

You're welcome! If you want to get more technical the problem was that traps while they can be picked up, the ingame action is "retrap" instead so depending on the "pickup order setting" it wasn't able to differentiate these 2 cases

Got crashed in 2 players game. I was the server.

Lua traceback: https://pastebin.com/EZSjHuJX

List of installed mods:
Admin Scoreboard+
Quick Drop - Client Version
Improved Force Attack
Mouse Through
Disable Mod Warnings
Show Me
Craft Pot [DS, ROG, SW, DST]
Followers For Everyone!
[API] Gem Core
Global Pause
Boss Indicators
Geometric Placement
Wall Map Icons
Simple Health Bar DST
Global Positions
Wormhole Marks [DST]
Minimap HUD
Combined Status

Originally posted by bIbIbI(rus):

Got crashed in 2 players game. I was the server.

Lua traceback: https://pastebin.com/EZSjHuJX

List of installed mods:
Admin Scoreboard+
Quick Drop - Client Version
Improved Force Attack
Mouse Through
Disable Mod Warnings
Show Me
Craft Pot [DS, ROG, SW, DST]
Followers For Everyone!
[API] Gem Core
Global Pause
Boss Indicators
Geometric Placement
Wall Map Icons
Simple Health Bar DST
Global Positions
Wormhole Marks [DST]
Minimap HUD
Combined Status

Thanks for reporting, should be fixed by now :)

That was fast. Thanks, man! :)

Got a repeatable crash on a player-hosted single-shard game, when another player tries to use bugnet to catch a bee.

00:05:54]: [string "../mods/workshop-1603516353/modmain.lua"]:455: attempt to call global 'ValidateBugNet' (a nil value)
LUA ERROR stack traceback:
../mods/workshop-1603516353/modmain.lua:455 in (method) GetActionButtonAction (Lua) <405-547>
scripts/components/playercontroller.lua:1623 in (method) OnRemoteActionButton (Lua) <1619-1640>
scripts/networkclientrpc.lua:126 in () ? (Lua) <115-128>
=[C]:-1 in (method) CallRPC (C) <-1--1>
scripts/networkclientrpc.lua:932 in (global) HandleRPCQueue (Lua) <923-940>
scripts/update.lua:41 in () ? (Lua) <33-129>

Log: https://hastebin.com/eqirocohem.md

Don't really have a quick list of installed mods, but I keep them (and many others) in my collections:
Client mods: https://steamproxy.net/sharedfiles/filedetails/?id=475185498
Server mods: https://steamproxy.net/sharedfiles/filedetails/?id=852612796

Originally posted by myxal:

Got a repeatable crash on a player-hosted single-shard game, when another player tries to use bugnet to catch a bee.

00:05:54]: [string "../mods/workshop-1603516353/modmain.lua"]:455: attempt to call global 'ValidateBugNet' (a nil value)
LUA ERROR stack traceback:
../mods/workshop-1603516353/modmain.lua:455 in (method) GetActionButtonAction (Lua) <405-547>
scripts/components/playercontroller.lua:1623 in (method) OnRemoteActionButton (Lua) <1619-1640>
scripts/networkclientrpc.lua:126 in () ? (Lua) <115-128>
=[C]:-1 in (method) CallRPC (C) <-1--1>
scripts/networkclientrpc.lua:932 in (global) HandleRPCQueue (Lua) <923-940>
scripts/update.lua:41 in () ? (Lua) <33-129>

Log: https://hastebin.com/eqirocohem.md

Don't really have a quick list of installed mods, but I keep them (and many others) in my collections:
Client mods: https://steamproxy.net/sharedfiles/filedetails/?id=475185498
Server mods: https://steamproxy.net/sharedfiles/filedetails/?id=852612796

Hey, thanks for the report. I wasn't able to reproduce the bug myself but I looked into the code and I think I found the reason why it was crashing. I pushed an update so let me know if that fixed the problem!

Doesn't crash anymore, thanks! :)

I am getting a lot of frame skips when pressing my 'space' key, I believe it is because of this mod, do you know what could be causing it?

It seems that in modmain, line 316, the ValidateCorpseReviver seems is called without a check, and in custom modes like starving floor it can crash the client when resurrecting

Hello! I'd like to report six bugs:

1. If playing as Wes, who can't tend to farm plants, the mod still tries to anyway, which prevents any other action from being done when an untended farm plant is nearby because the mod continually tries to tend to the farm plant, causing Wes to just stand still and do nothing.

2. Same thing as above, but with any character when near a burning farm plant, previously tended to or otherwise.

These two can be fixed by replacing line 318 of 'modmain.lua' with line 1468 of 'components/playercontroller.lua'.

3. If the 'Pick up first' option is enabled, the mod will attempt to pick up smoldering items, which is only possible if the action is attempted before the item starts smoldering. This causes a similar issue to the first two, where holding space won't do anything if the player is near a smoldering item.

I have two ways to fix this, depending on what you want the behaviour to be:

1. If you want smoldering items to simply be ignored if there are non-smoldering items to pick up, then add ' or target:HasTag("smolder")' in the parentheses on line 237 of 'modmain.lua'.

2. If you want smoldering items to be extinguished, thus rendering them able to be picked up, then replace the code on line 375 of 'modmain.lua' with these five lines:

if target:HasTag("smolder") then
return target, ACTIONS.SMOTHER
else
return target, ACTIONS.PICKUP
end

4. While fighting the ancient fuelweaver, the key can be removed from the gateway with space; the key is meant to be impossible to remove once the fuelweaver has been summoned.

5. While using the moon stone to turn a star caller's staff into a moon caller's staff, the star caller's staff can still be removed with space after the second stage has been reached; the staff is meant to only be removable before the second stage.

I have two ways to fix these two, depending on how you want the code to look:

1. Add ' and not target:HasTag("intense")' to the elseif check on line 297 of 'modmain.lua'.

2. Add the 'PICKUP_TARGET_EXCLUDE_TAGS' table on line 1501 of 'components/playercontroller.lua' to a new line on line 404 of 'modmain.lua'. If you do this, you can remove ' or target:HasTag("catchable") or target:HasTag("mineactive")' from line 237 of 'modmain.lua'.

6. The mod doesn't work while mounted on a beefalo or Woby.

This can be fixed by modifying the 'SetActionFilter' function on line 137 of 'components/rider_replica.lua' in a similar way to how the mod modifies the 'GetActionButtonAction' function on line 1511 of 'components/playercontroller.lua'.

I hope this was helpful. Thank you for making an awesome mod.

Originally posted by bjanmanjs:

Hello! I'd like to report six bugs:

1. If playing as Wes, who can't tend to farm plants, the mod still tries to anyway, which prevents any other action from being done when an untended farm plant is nearby because the mod continually tries to tend to the farm plant, causing Wes to just stand still and do nothing.

2. Same thing as above, but with any character when near a burning farm plant, previously tended to or otherwise.

These two can be fixed by replacing line 318 of 'modmain.lua' with line 1468 of 'components/playercontroller.lua'.

3. If the 'Pick up first' option is enabled, the mod will attempt to pick up smoldering items, which is only possible if the action is attempted before the item starts smoldering. This causes a similar issue to the first two, where holding space won't do anything if the player is near a smoldering item.

I have two ways to fix this, depending on what you want the behaviour to be:

1. If you want smoldering items to simply be ignored if there are non-smoldering items to pick up, then add ' or target:HasTag("smolder")' in the parentheses on line 237 of 'modmain.lua'.

2. If you want smoldering items to be extinguished, thus rendering them able to be picked up, then replace the code on line 375 of 'modmain.lua' with these five lines:

if target:HasTag("smolder") then
return target, ACTIONS.SMOTHER
else
return target, ACTIONS.PICKUP
end

4. While fighting the ancient fuelweaver, the key can be removed from the gateway with space; the key is meant to be impossible to remove once the fuelweaver has been summoned.

5. While using the moon stone to turn a star caller's staff into a moon caller's staff, the star caller's staff can still be removed with space after the second stage has been reached; the staff is meant to only be removable before the second stage.

I have two ways to fix these two, depending on how you want the code to look:

1. Add ' and not target:HasTag("intense")' to the elseif check on line 297 of 'modmain.lua'.

2. Add the 'PICKUP_TARGET_EXCLUDE_TAGS' table on line 1501 of 'components/playercontroller.lua' to a new line on line 404 of 'modmain.lua'. If you do this, you can remove ' or target:HasTag("catchable") or target:HasTag("mineactive")' from line 237 of 'modmain.lua'.

6. The mod doesn't work while mounted on a beefalo or Woby.

This can be fixed by modifying the 'SetActionFilter' function on line 137 of 'components/rider_replica.lua' in a similar way to how the mod modifies the 'GetActionButtonAction' function on line 1511 of 'components/playercontroller.lua'.

I hope this was helpful. Thank you for making an awesome mod.

Damn, this mod was supposed to be a few-liner, but it gets more and more special conditions.
Thank you for such a thorough investigation, you basicly found the solutions to most of the bugs. I'll try to implement your fixes into the mod in the upcoming days when I get some free time