RimWorld

RimWorld

33 ratings
Combat Training - Unofficial CE Patch
   
Award
Favorite
Favorited
Unfavorite
Mod, 1.0, 1.1, 1.2
File Size
Posted
Updated
240.973 KB
9 May, 2019 @ 10:47pm
5 Nov, 2020 @ 9:13am
5 Change Notes ( view )

Subscribe to download
Combat Training - Unofficial CE Patch

Description
A simple patch to make bohedo's Combat Training mod more compatible with Combat Extended.

Adds CE_OneHandedWeapon as weaponTags so that pawns equipped with shields can actually train and not fall into a loop of equipping and unequipping the training weapons.

Update 1-5-20: Ranged training weapons should now be made compatible with CE's ammo system, which should hopefully make load order less of an issue. This doesn't mean you now have to craft ammo to train, as they should both have infinite ammo.

Update 11-5-20: About.cml now includes 1.2 in list of supported versions. Also changed dependencies to work with the forked variant of Combat Training. It seems to work on my end, but I've done minimal testing.
48 Comments
rebelscum  [author] 18 Apr, 2023 @ 8:01pm 
@Anrock i couldn't say. give it a shot and let us know? an error at startup might indicate that it's not supported by 1.4, but like my previous comment says, it could be a safely ignored warning. for all i know at this point, the original incompatibility between the two mods was taken care of on their end. but i haven't played in over a year.
Anrock 18 Apr, 2023 @ 9:19am 
Does it support 1.4?
rebelscum  [author] 24 May, 2022 @ 9:36pm 
@onestrongbow never had any trouble with it in 1.3. the only thing i can think of would be if i never updated the about.xml to reflect that, you might get an error on start up, but it's safe to ignore. if it annoys you, you can edit the about.xml to include 1.3 pretty easily in the supportedVersions section.
onestrongbow GocleCD 24 May, 2022 @ 12:11pm 
1.3 compatible ?
rebelscum  [author] 15 Jan, 2021 @ 6:32pm 
No worries, I understand.
pizzasheepz 15 Jan, 2021 @ 6:19pm 
Ah, thats completely okay! I didnt know where it was coming from so I figured the patch was the most likely cause of this. I'll reach out to him sometime soon. Thanks for all your help and sorry about bothering you!
rebelscum  [author] 15 Jan, 2021 @ 5:16pm 
Based off the mod description (didn't download it to look at what's underneath the hood), Rimmu-nation shouldn't be affecting this one way or another.

As for load order, definitely recommend loading this after Combat Training. So CE, Combat Training, this.

Those errors suggest to me that it's something going on on the Combat Training side of things. I'd reach out to helldragger over on the forked variant. This mod is only dealing in xml patches, not in any addition or modification to C# code. So if it does happen to have something to do with the interaction of CE and Combat Training, and not just something on Combat Training's side, then either of those teams would have to address it, since I can't write C#.

Hope this helps.
pizzasheepz 15 Jan, 2021 @ 3:27pm 
I have had a look and the bug is really illusive. It seems to occur only randomly, and usually no log is spawned from it. I got one log that would pop up regularly, and one that may been caused from me switching around mod order. Here is a link to a Doc containing all the logs, as well as my testing. Sadly, I don't think I have enough info to point to why this may be happening, but hopefully those logs can help a little?
https://docs.google.com/document/d/1sli3S5uCyFrZRrBxHzW6oFqjcIJibbu_D1NZxTlv23M/edit?usp=sharing
rebelscum  [author] 15 Jan, 2021 @ 10:55am 
If pawns have ranged equipped (not just in inventory/loadout) and aren't training ranged on free, accessible dummies set to ranged, I think that's gonna be on the Combat Training side of things. Maybe mod interaction/conflict? Do training bows work? If you get rid of all the training weapons, pawns should use their currently equipped weapons (keep a backup save before doing this, weapons will do full damage.)

I guess there aren't any errors that pop up? check in dev mode, see if non-critical messages pop up in the log as pawns go to train. That could give a clue what's happening. Maybe messing around with load order, trying both different orders of the three mods (CE, Combat Training, and this patch) as well as trying with just Combat Training. Maybe trying to switch between Combat Training and Combat Training - Forked?

Also, it's been a while since I've played, but are you able to right click to force them to train on the dummies? Does that work for ranged?
pizzasheepz 14 Jan, 2021 @ 2:14pm 
Afraid that isnt the issue. I have a three set to melee only and 3 set to ranged only, they have no problem with switching to the training knives, but they just wont change over to the BB gun. As far as I can tell, there is no mod conflict, since it happens across all races and weapon types (vanilla or otherwise) I'll do some in depth testing soon but it just seems like it randomly breaks. I had a fresh world setup with the exact same mods and it worked fine, but the original save I have wasnt working (And that also had the same mods, none added.)